Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install.sh: Add brew integration and documentation #121

Merged
merged 3 commits into from Nov 21, 2022

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Nov 21, 2022

Updates #80

@nhooyr
Copy link
Contributor Author

nhooyr commented Nov 21, 2022

I updated the log output with a colored big header for next steps (re https://github.com/terrastruct/d2/pull/114/files)

Please test @alixander

Screenshot 2022-11-20 at 6 51 20 PM

Screenshot 2022-11-20 at 6 51 27 PM

Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we turn off brew's autoupdate? https://apple.stackexchange.com/questions/293250/how-to-install-an-homebrew-formula-without-updating-homebrew-itself

my homebrew just started updating random shit, as it does.

ci/release/_install.sh Show resolved Hide resolved
ci/release/_install.sh Show resolved Hide resolved
ci/release/_install.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, why did it update my go version. is the dependency set to be the latest go?

Screen Shot 2022-11-20 at 7 11 38 PM

README.md Show resolved Hide resolved
install.sh Show resolved Hide resolved
nhooyr added a commit to terrastruct/homebrew-tap that referenced this pull request Nov 21, 2022
@nhooyr
Copy link
Contributor Author

nhooyr commented Nov 21, 2022

huh, why did it update my go version. is the dependency set to be the latest go?

Fixed, see terrastruct/homebrew-tap@446e294

docs/INSTALL.md Outdated Show resolved Hide resolved
ci/release/_install.sh Outdated Show resolved Hide resolved
@nhooyr nhooyr merged commit 05c1360 into terrastruct:master Nov 21, 2022
@nhooyr nhooyr deleted the installsh branch November 21, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants