Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile: no empty block strings #1364

Merged
merged 7 commits into from
Jun 2, 2023
Merged

compile: no empty block strings #1364

merged 7 commits into from
Jun 2, 2023

Conversation

berniexie
Copy link
Contributor

Throw a compiler error for empty block strings.

@berniexie berniexie requested review from alixander and a team June 2, 2023 01:56
@berniexie berniexie marked this pull request as ready for review June 2, 2023 01:56
alixander
alixander requested changes Jun 2, 2023
View reviewed changes
d2compiler/compile.go Outdated Show resolved Hide resolved
@berniexie berniexie requested a review from alixander June 2, 2023 18:12
@berniexie berniexie merged commit 69b816c into terrastruct:master Jun 2, 2023
2 checks passed
@berniexie berniexie deleted the no-empty-block-strings branch June 2, 2023 18:30
@alixander alixander mentioned this pull request Jun 8, 2023
Closed
@chenrui333 chenrui333 mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@berniexie @alixander