Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: improve tooltip url check #1390

Merged
merged 4 commits into from
Jun 9, 2023
Merged

compiler: improve tooltip url check #1390

merged 4 commits into from
Jun 9, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Jun 9, 2023

Summary

Improve tooltip URL check to ignore values without a host.

Details

@gavin-ts gavin-ts changed the title Improve tooltip url check compiler: improve tooltip url check Jun 9, 2023
@gavin-ts gavin-ts requested a review from alixander June 9, 2023 21:16
@gavin-ts gavin-ts marked this pull request as ready for review June 9, 2023 21:16
@gavin-ts gavin-ts enabled auto-merge June 9, 2023 21:16
@gavin-ts gavin-ts merged commit f561b83 into terrastruct:master Jun 9, 2023
2 checks passed
@Porkepix Porkepix mentioned this pull request Jun 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

url detection too loose
2 participants
@gavin-ts @alixander