Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d2ir: Globs #1479

Merged
merged 15 commits into from
Jul 30, 2023
Merged

d2ir: Globs #1479

merged 15 commits into from
Jul 30, 2023

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Jul 13, 2023

No description provided.

@nhooyr nhooyr marked this pull request as ready for review July 30, 2023 00:15
@nhooyr nhooyr enabled auto-merge July 30, 2023 00:15
@nhooyr nhooyr changed the title Globs d2ir: Globs Jul 30, 2023
d2ir/d2ir.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't inspect all the boilerplate code, but i understand the implementation

d2ir/pattern.go Show resolved Hide resolved
d2ir/d2ir.go Show resolved Hide resolved
d2ir/d2ir.go Show resolved Hide resolved
d2ir/d2ir.go Outdated Show resolved Hide resolved
d2ir/d2ir.go Outdated Show resolved Hide resolved
d2ir/d2ir.go Outdated Show resolved Hide resolved
@nhooyr nhooyr requested a review from alixander July 30, 2023 19:43
@nhooyr nhooyr merged commit 17cb936 into terrastruct:master Jul 30, 2023
2 checks passed
@nhooyr nhooyr deleted the globs branch July 30, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants