Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple edges in grid #1586

Merged
merged 16 commits into from
Sep 15, 2023
Merged

Simple edges in grid #1586

merged 16 commits into from
Sep 15, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Sep 13, 2023 •
edited

Summary

Grid diagrams now have basic support for edges between children.

Details

  • fixes support edges within grid diagrams #1145
  • adds simple_grid_edges test (created based on example in support edges within grid diagrams #1145)
  • edges between shapes in grid diagrams have basic center-to-center edge routing
    • currently they must be direct children of the grid
  • edges from outside a grid to inside one, or in descendants are still not allowed
  • adds grid_nested_simple_edges test to demonstrate where nested edges are currently supported in relation to grids
  • updates compiler validation and tests
  • TODO followup update nested layout design to support general edge nesting through several layouts (see Redesign nested layout #1602)

new test with edges in grid

_Users_gavinnishizawa_github_repos_d2_e2etests_testdata_stable_simple_grid_edges_dagre_sketch exp svg (1)

new test showing where nested edges are currently supported

_Users_gavinnishizawa_github_repos_d2_e2etests_testdata_stable_grid_nested_simple_edges_dagre_sketch exp svg

@gavin-ts gavin-ts requested a review from a team September 14, 2023 04:21
@gavin-ts gavin-ts marked this pull request as ready for review September 14, 2023 04:21
@alixander alixander mentioned this pull request Sep 14, 2023
Closed
alixander
alixander approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow diagram looks great

@gavin-ts gavin-ts merged commit b84a51e into terrastruct:master Sep 15, 2023
2 checks passed
@Porkepix Porkepix mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alixander alixander alixander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support edges within grid diagrams
2 participants
@gavin-ts @alixander