Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler: Fix errors in globs #1691

Merged
merged 1 commit into from
Oct 31, 2023
Merged

compiler: Fix errors in globs #1691

merged 1 commit into from
Oct 31, 2023
+69 −4

Conversation

alixander
Copy link
Collaborator

fixes #1676

  1. This picks up refs set by globs so that the error gets the right ref.
  2. Which also adds a dedupe to the compiler list of errors since keys set by globs, if errored, will report multiple errors emanating from the same range.

@alixander alixander force-pushed the glob-label-near branch 3 times, most recently from b551ad6 to c270bc8 Compare October 31, 2023 19:33
gavin-ts
gavin-ts reviewed Oct 31, 2023
View reviewed changes
d2ir/d2ir.go Outdated Show resolved Hide resolved
gavin-ts
gavin-ts approved these changes Oct 31, 2023
View reviewed changes
d2ir/d2ir.go Outdated Show resolved Hide resolved
gavin-ts
gavin-ts suggested changes Oct 31, 2023
View reviewed changes
d2ir/d2ir.go Outdated Show resolved Hide resolved
gavin-ts
gavin-ts reviewed Oct 31, 2023
View reviewed changes
d2ir/d2ir.go Outdated Show resolved Hide resolved
@alixander alixander merged commit 92ef0b7 into terrastruct:master Oct 31, 2023
3 checks passed
@alixander alixander deleted the glob-label-near branch October 31, 2023 23:04
@alixander alixander mentioned this pull request Nov 7, 2023
Closed
@BrewTestBot BrewTestBot mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-ts gavin-ts gavin-ts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

glob compiler crash
2 participants
@alixander @gavin-ts