Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix appendix icon numbering/order #1704

Merged

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Nov 7, 2023

Summary

Fixes incorrect appendix icon numbering.

Details

  • fixes Tooltip numbering wrong in PNG export #1703
  • appendix tooltip/link icons used to be replaced in the svg according to their numbered order, but the icons in the svg are ordered according to the render order
  • fixes appendix creation to replace each rendered icon with the correct number icon

example from #1703

X is defined first so X should get 1 and Y 2, but X is rendered after Y and all the other 1st level shapes because it has to appear in front of its parent container.
Previously this meant the 1st icon in the svg was Y's icon which was incorrectly replaced with a 1 icon.

Block: {
  X: {tooltip: X}
}
Y: {tooltip: Y}

before

Screenshot 2023-11-06 at 4 36 28 PM

after

Screenshot 2023-11-06 at 4 36 35 PM

@gavin-ts gavin-ts marked this pull request as ready for review November 7, 2023 00:47
@gavin-ts gavin-ts merged commit 7f9dcf7 into terrastruct:master Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip numbering wrong in PNG export
2 participants