Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shaped grid positioning and circle innerBox/sizing #1734

Merged
merged 13 commits into from
Nov 16, 2023

Conversation

gavin-ts
Copy link
Contributor

@gavin-ts gavin-ts commented Nov 16, 2023

Summary

Fixes grid positioning of contents when the grid is a shape with a custom innerBox.
Also fixes the circle shape sometimes actually being too small to fit its content in its innerBox.

Details

before/after

Screenshot 2023-11-15 at 8 28 07 PM

before/after with innerBoxes highlighted

Screenshot 2023-11-15 at 8 25 06 PM

e2ereport

_Users_gavinnishizawa_github_repos_d2_e2etests_out_e2e_report html (8)

@gavin-ts gavin-ts changed the title fix circle shape sizing and shaped grid positioning fix shaped grid positioning and circle innerBox/sizing Nov 16, 2023
@gavin-ts gavin-ts marked this pull request as ready for review November 16, 2023 05:21
Copy link
Collaborator

@alixander alixander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2023-11-15 at 9 28 29 PM

is this right? why's it look off?

@gavin-ts
Copy link
Contributor Author

gavin-ts commented Nov 16, 2023

Screen Shot 2023-11-15 at 9 28 29 PM is this right? why's it look off?

this is how this test tries to replicate in #1674 . I think the label dimensions of the character used aren't exactly square/centered

Screenshot 2023-11-15 at 9 32 00 PM

Here is the character highlighted on master:

Screenshot 2023-11-15 at 9 35 38 PM

Here is it now (correctly fits inside innerbox):

Screenshot 2023-11-15 at 9 37 25 PM

ci/release/changelogs/next.md Outdated Show resolved Hide resolved
@gavin-ts gavin-ts merged commit 4a30bd2 into terrastruct:master Nov 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grid container with shape circle doesn't position cells correctly
2 participants