wip: Reserved keywords only unquoted #800
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhooyr
reviewed
Feb 12, 2023
| Name: head, | ||
| parent: m, | ||
| Name: headString, | ||
| IsUnquoted: headUnquoted, |
There was a problem hiding this comment.
You also need to check that there are no escapes. Use len(headString) == len(head.(*d2ast.UnquotedString).RawString). i.e there are no escapes if the length of the string value is equal to it's length in the AST.
There was a problem hiding this comment.
IsUnquoted could be confusing then, but i can't think of a word that encapsulates "is unquoted or is escaped". Raw already means something else. will leave as IsUnquoted for now unless u have a word
There was a problem hiding this comment.
Yea just add a comment on IsUnquoted. I have no better word in mind.
|
I wait this one, to remove trailing space in quoted reserved keywords! Related: #1419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nhooyr spot check before i go too far on this. there's a number of places where we iterate over
idaand check reserved. those will be annoying, as we now have to change them to carry info about their original AST quoting. E.g. there's a lot of ScalarString() conversions made too early nowcloses #477