Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard ability for htaccess filename checking #158

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Conversation

ethanaobrien
Copy link
Collaborator

@ethanaobrien ethanaobrien commented Sep 4, 2023

if the requested file is abc.html and the server is told to do something at *.html, it will do it.
if the requested file is abc.html and the server is told to do something at abc.*, it will do it.
if the requested file is abc.html and the server is told to do something at *, it will do it.

Also fixes a small (major) bug with the redirection using the no .html extension option

The htaccess feature is pretty much done - just needs some documentation behind it

ps: (unrelated note) sorry for any immaturity I've shown when working in the past. Ive been working quite a bit and am really confident in my coding now.

@terreng
Copy link
Owner

terreng commented Sep 4, 2023

ps: (unrelated note) sorry for any immaturity I've shown when working in the past. Ive been working quite a bit and am really confident in my coding now.

There's no need to apologize! I'm glad you're able to reflect. It shows a significant level of maturity and self-awareness. Remember that growth and learning are ongoing processes. I've certainly learned a lot from maintaining this project too.

It's great to see how far you've come in the time we've been working together. It seems like you've grown a lot over the last couple years. Your commitment to improving your coding skills is commendable, and I'm glad that you've become more proficient and confident.

I really appreciate your contributions to this project. It wouldn't have happened without you. I think we've made a great team.

Please don't hesitate to reach out if you need anything. If you ever want to chat about other projects, college plans, or anything else, I'd love to get to know you a little better. No pressure at all, but I think you have my email and I can give you my discord or something if you want.

Keep up the excellent work! :)

@terreng terreng merged commit 0dc8d2d into main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants