Made the buttons usable for modern client #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to get this right: they now work on both modern and classic? |
|
Yes. Another PR will follow the next days so that the icons in modern toolkit are also visible, currently they are not because of no support for glyphs in modern toolkit |
|
Pnce I have time to cjeck this in my apps I'll 👍 this. If it is urgent, please ping e.g. @KaiVolland |
|
Take your time 👍 |
|
Display of icons has been fixed. Modern toolkit uses html, classic uses glyph. |
|
Very nice work, applied cleanly and works fine in two other apps. Thanks, @weskamm, please merge. |
|
thx, will merge |
weskamm
added a commit
that referenced
this pull request
Nov 24, 2015
Made the buttons usable for modern client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all current buttons to extend from
Ext.Buttoninstead ofExt.button.Button.This way they are compatible with the classic and modern toolkit.
There are still buttons which cannot be used in the modern toolkit (Permalink, AddWms and CoordinateTransform), because they rely on classic components like windows.
Other changes involved are the usage of the constructor and moving the button handlers to the config object.
The tooltip binding had to be taken special care of because the "modern" buttons dont support the
setToolTipmethod.