Introduce some utils #431
Merged
Introduce some utils #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annarieger
approved these changes
Apr 17, 2019
dnlkoch
approved these changes
Apr 17, 2019
marcjansen
approved these changes
Apr 17, 2019
|
@marcjansen i added the most basic tests in e9a6604, but you're right. we should add "real" tests in follow-up PRs |
|
Thx for the reviews, i'll merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with @weskamm i migrated some utils from projects to BasiGX.
Major changes are only in 9c4905e so it makes sense to have a sharper look here.
All other utils are new and did not lead to changes in existing classes.