-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: allow OpenLayers Filter instances in WfsFilterUtil #1349
Conversation
Partially solves !22 |
6ae5eb4
to
b36a6be
Compare
* @private | ||
*/ | ||
static createWfsFilter( | ||
featureType: string, | ||
searchTerm: string, | ||
attributeDetails: AttributeDetails | ||
): OlFormatFilter | null { | ||
): OlFilter | undefined { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this one a breaking change? (method return type is changed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed OlFormatFilter
to OlFilter
, so here's no breaking change imho. On the other hand, I agree that switch of null
to undefined
is rather a breaking change. I'll change the commit message accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check again @annarieger 🙏🏼
BREAKING CHANGE: createWfsFilter returs an OLFilter instance / undefined now
b36a6be
to
1e01896
Compare
🎉 This PR is included in version 16.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR introduces some new functionality to the existing
WfsFilterUtil
such that filters created byattributeDetails
in asearchConfig
can eitherAnd
- filter), e.g.If no
filter
is passed insearchConfig
, the filter creation is performed as currently implemented.Plz review @terrestris/devs