Upgrade ol5 #8
Merged
Upgrade ol5 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahennr
approved these changes
Aug 14, 2018
src/MeasureUtil/MeasureUtil.spec.js
Outdated
| @@ -38,8 +38,8 @@ describe('MeasureUtil', () => { | |||
| const expectedShortLength = MeasureUtil.getLength(shortLine, map); | |||
| const expectedLongLength = MeasureUtil.getLength(longLine, map); | |||
|
|
|||
| expect(expectedShortLength).toEqual(99.99999999669033); | |||
| expect(expectedLongLength).toEqual(100545.83533277796); | |||
| expect(expectedShortLength).toEqual(99.88824008937313); | |||
There was a problem hiding this comment.
Also, floats/doubles should not be checked for equality, but compared using a delta (0.1 + 0.2 !== 0.3).
There was a problem hiding this comment.
The default sphere radius taken into account for length/area calculation in ol is set to 6371008.8 whereas the previous implementation in ol-util used the non-default value 6378137 (that is the value equal to the semi-major axis of the WGS84 ellipsoid).
If needed the value may be passed to the corresponding util methods, but in here I would like to make use of the same radius as used in ol per default.
There was a problem hiding this comment.
@hwbllmnn Yes, absolutely! Fixed (and will be fixed for all other occurrences in a separate PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
ol-utilclasses to make use of the current version ofol(5.1.3).In addition eslint is added.