terrestris#503 add mm to formatLength and formatArea #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. Could you please add a test and update API documentation? Please ping us if you need help |
|
Thanks for your quick response. However, how can I add a test for this ? @marcjansen |
|
Hi @DieuAnh, thanks for your contribution! The existing tests for the formatLength() and formatArea() methods might give you a good starting point. In principle a test should assert if an input value (e.g. a line with the length of 0.1 meters) will result in the expected output value (e.g. 100 mm). |
|
Hello @dnlkoch, |
dnlkoch
approved these changes
Jan 4, 2023
|
Thanks @DieuAnh! |
|
🎉 This PR is included in version 10.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added mm in format length and format area for the tooltip. It's needed for my work project. Please review. Thank you.