Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heap space issues for tests #100

Merged
merged 2 commits into from Sep 22, 2017
Merged

Conversation

KaiVolland
Copy link
Member

@KaiVolland KaiVolland commented Sep 22, 2017

Hopefully this PR will fix the heap space and no message in 10000 ms issues we have with the tests.

It adds max_old_space_size=4096 option to the test scripts.

Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

@@ -49,17 +49,18 @@
"clean:build": "rimraf ./build/*",
"clean:dist": "rimraf ./dist/*",
"pretest": "npm run lint",
"test": "npm run clean:test && BABEL_ENV=coverage karma start karma.conf.js --single-run",
"test": "npm run clean:test && BABEL_ENV=coverage karma start karma.conf.js --single-run -- --max_old_space_size=4096",
"test:phantom": "npm run clean:test && BABEL_ENV=coverage karma start karma.conf.js --single-run --browsers PhantomJS -- --max_old_space_size=4096",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tha could probably be simplified to

npm run test -- --browsers PhantomJS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No i didn't work because we allready got -- --max_old_space_size=4096 in test.

@KaiVolland KaiVolland merged commit 0b9e29c into terrestris:master Sep 22, 2017
@KaiVolland KaiVolland deleted the space-tests branch September 27, 2017 13:20
hblitza pushed a commit that referenced this pull request Oct 19, 2022
Update np to the latest version 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants