New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escape key for IE #1053

Merged

annarieger merged 1 commit into terrestris:master from annarieger:fix-esc-key

Feb 22, 2019

Member

annarieger commented Feb 22, 2019

BUGFIX

Description:

Tiny fix to ensure that Escape key will also be matched while using IE.

Please review @terrestris/devs


          fix escape key for IE

5b162a0

Member

marcjansen commented Feb 22, 2019

How about using evt.keyCode? It feels as if this is better for cross browser compatibility, I have no proof though.

https://keycode.info/ & https://developer.mozilla.org/de/docs/Web/API/KeyboardEvent/keyCode have insides, can be tested in the various browsers.

hwbllmnn approved these changes

View reviewed changes

Member

hwbllmnn left a comment

According to https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key I think this should be safe, especially since https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode is deprecated.

Member Author

annarieger commented Feb 22, 2019 •

edited

Loading

keyCode is deprecated --> https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode

annarieger merged commit 9712aa4 into terrestris:master

annarieger deleted the fix-esc-key branch

February 22, 2019 12:18

Member

marcjansen commented Feb 22, 2019

Fine for me, even though support for key isn't so great as well: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key#Browser_compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment