Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces TypeScript #1212

Merged
merged 69 commits into from
Nov 12, 2019
Merged

Introduces TypeScript #1212

merged 69 commits into from
Nov 12, 2019

Conversation

KaiVolland
Copy link
Member

@KaiVolland KaiVolland commented Jul 5, 2019 •
edited

BREAKING CHANGE

Description:

This transforms the project to use and be build with TypeScript.

Componentss:

  • Button
  • CircleMenu
  • Container
  • Field
  • Grid
  • HigherOrderComponent
  • LayerTree
  • LayerTreeNode
  • Legend
  • Map
  • Panel
  • Provider
  • Slider
  • Toolbar
  • UserChip
  • Window
  • Util

TODOs:

  • Tests
  • Styleguide
    • Fix Examples

Closes #1240
Closes #1241

@KaiVolland
Copy link
Member Author

tsc currently failing because of: ag-grid/ag-grid#3492

@KaiVolland
Setup TypeScript
34462da
@KaiVolland
Transforms constants to TypeScript
e5eeff2
@KaiVolland
Transforms UserChip to TypeScript
28e5ecf
@KaiVolland
Transforms Toolbar to TypeScript
0583447
@KaiVolland
Adds @types/jest and @types/enzyme
7e84e1b
@KaiVolland
Transforms Window to TypeScript
b706916
@KaiVolland
Adjust JS-Docs for TestUtil
b7a7249
@KaiVolland
Transforms TimeSlider to TypeScript
88af885
@KaiVolland
Transforms LayerTransparencySlider to TypeScript
77fb988
@KaiVolland
Transforms MultiLayerSlider to TypeScript
0b6c0d3
@KaiVolland
Transforms MapProvider to TypeScript
51f8128
@KaiVolland
Transforms Titlebar to TypeScript
d356bf1
@KaiVolland
Transforms Panel to TypeScript
a8cc208
@KaiVolland
Transforms MapComponent to TypeScript
e4ee1a4
@KaiVolland
Transforms FloatingMapLogo to TypeScript
055e69e
@KaiVolland
Transforms Legend to TypeScript
46c56ae
@KaiVolland
Transforms LayerTreeNode to TypeScript
1fe25bd
@KaiVolland
Transforms LayerTree to TypeScript
7ba46be
@KaiVolland
Transforms VisibleComponent to TypeScript
1360c51
@KaiVolland
Misc code improvements
9fe71a2
@KaiVolland
Updates typescript related packages
fc9367f
@KaiVolland
Transforms TimeLayerAware to TypeScript
bfd6dbe
@KaiVolland
Transforms MappifiedComponent to TypeScript
04ca7ca
@KaiVolland
Transforms LoadifiedComponent to TypeScript
9f3b3ca
@KaiVolland
Transforms DropTargetMap to TypeScript
d5d31d0
@KaiVolland
Transforms PropertyGrid to TypeScript
a1407e5
@KaiVolland
Transforms FeatureGrid to TypeScript
559f33e
@marcjansen marcjansen added this to the run milestone Nov 8, 2019
@KaiVolland KaiVolland changed the title [WIP] TypeScript Introduce TypeScript Nov 11, 2019
@KaiVolland
Copy link
Member Author

The build is currently failing due to a bug in ag-grid/ag-grid#3492 when using the latest TypeScript version (3.7.2). Therefore the TypeScript version is pinned to "~3.6.0". I'll open an issue once this is PR is merged.

dnlkoch
dnlkoch approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, buddy!

giphy

package.json Show resolved Hide resolved
babel.config.js Show resolved Hide resolved
package.json Show resolved Hide resolved
webpack.common.config.js Outdated Show resolved Hide resolved
@KaiVolland KaiVolland changed the title Introduce TypeScript Introduces TypeScript Nov 11, 2019
ahennr
ahennr approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@ahennr ahennr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really impressive work @KaiVolland

🔝

https://media.giphy.com/media/3o6vXZyyH0wFoEZmQU/giphy.gif

Just some non-blocking questions

src/Button/DigitizeButton/DigitizeButton.tsx Show resolved Hide resolved
src/Button/ToggleButton/ToggleButton.tsx Show resolved Hide resolved
src/Button/ToggleGroup/ToggleGroup.tsx Show resolved Hide resolved
src/Button/UploadButton/UploadButton.tsx Show resolved Hide resolved
src/Grid/PropertyGrid/PropertyGrid.tsx Outdated Show resolved Hide resolved
src/Grid/PropertyGrid/PropertyGrid.tsx Outdated Show resolved Hide resolved
@KaiVolland
Copy link
Member Author

Thx for the review @ahennr. There is still a lot room for TypeScript improvements and you already found some lines.
This PR is jus the introduction and we should improve typings as much as possible in the near future.

@KaiVolland
Copy link
Member Author

Bug in ag-grid types was fixed in ag-grid v 22.0.0 so i could upgrade to TypeScript 3.7.2.

@KaiVolland
Copy link
Member Author

Thx for the reviews.

@KaiVolland KaiVolland merged commit 122baf6 into terrestris:master Nov 12, 2019
@KaiVolland KaiVolland deleted the typescript branch November 12, 2019 14:29
@marcjansen
Copy link
Member

Very nice friends!

@KaiVolland KaiVolland restored the typescript branch November 22, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahennr ahennr ahennr approved these changes

@dnlkoch dnlkoch dnlkoch approved these changes

@annarieger annarieger Awaiting requested review from annarieger

@weskamm weskamm Awaiting requested review from weskamm

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KaiVolland @marcjansen @dnlkoch @ahennr