Introduces MapProvider, mappify and MapComponent #195
Conversation
| */ | ||
| static propTypes = { | ||
| /** | ||
| * The children of this group. Typically a set of `ToggleButton`s. |
There was a problem hiding this comment.
docs are copy and pasted, I guess
| */ | ||
| map: PropTypes.oneOfType([ | ||
| PropTypes.instanceOf(OlMap), | ||
| PropTypes.func |
There was a problem hiding this comment.
I assume there is no way of actually telling apart any func from a true Promise, right?
There was a problem hiding this comment.
Maybe if we fix your following comment.
| ready: true | ||
| }); | ||
| } else { | ||
| props.map().then((map) => { |
There was a problem hiding this comment.
Hmm, surprised aboit the invocation of map here. or are we expecting a function that returns a Promise? This might be me not understanding Promises... if so just ignore this.
There was a problem hiding this comment.
Currently yes. But this makes no sense at all... I gonna check this.
| * | ||
| * Wrapped components will be checked against the activeModules array of | ||
| * the state: If the wrapped component (identified by it's name) is included | ||
| * in the state, it will be rendered, if not, it wont. |
| /** | ||
| * The wrapper class for the given component. | ||
| * | ||
| * @class The VisibleComponent |
| } = this.props; | ||
|
|
||
| if (map) { | ||
| mapDiv = <div className="map" id="map" {...passThroughProps} />; |
There was a problem hiding this comment.
This could be also passed as a prop and default could by id …
|
@marcjansen Thx for the catches. Gonna fix these soon. |
|
|
||
| /** | ||
| * The map can be either an OlMap or a Promise that resolves with an OlMap | ||
| * if your map is created asynchronusly. |
There was a problem hiding this comment.
asynchronusly -> asynchronously
| map: PropTypes.oneOfType([ | ||
| PropTypes.instanceOf(OlMap), | ||
| PropTypes.instanceOf(Promise) | ||
| ]) |
There was a problem hiding this comment.
The prop map should be marked as required.
| /** | ||
| * Returns the wrapped instance. Only applicable if withRef is set to true. | ||
| * | ||
| * @return {Element} The wrappend instance. |
| /** | ||
| * Class representating a map. | ||
| * | ||
| * @class The Map. |
| * @method componentDidMount | ||
| */ | ||
| componentDidMount() { | ||
| this.props.map.setTarget('map'); |
There was a problem hiding this comment.
Please make use of prop mapDivId here.
| mapDiv = <div | ||
| className="map" | ||
| id={mapDivId} | ||
| {...passThroughProps} |
There was a problem hiding this comment.
Please add the possibility to pass children to the div element.
This introduces the HOCs
MapProvidertheMappifiedComponent(mappify) and theMapComponent.Short explanation:
MapProvideradds a map to the context of the application.mappfiyfunction grabs the map from the context and adds it as prop to the according component.MapComponentjust returns a div containing an OlMap.It also includes an example of how to use these three new Components together.
We should check/modify our examples and tests to make use of the
MapProvider.Thx @dnlkoch and @ahennr for your support.