Added time slider, time layer aware HOC #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always updates the TIME parameter without checking the services constraints.
hwbllmnn
changed the title
dnlkoch
approved these changes
Jan 5, 2018
package.json
Outdated
| @@ -119,6 +119,7 @@ | |||
| "metalsmith-layouts": "1.8.1", | |||
| "metalsmith-markdown": "0.2.1", | |||
| "minami": "1.2.3", | |||
| "moment": "2.20.1", | |||
src/Slider/TimeSlider.jsx
Outdated
|
|
||
| /** | ||
| * The default value(s). | ||
| * @type {any} |
There was a problem hiding this comment.
Is there any other type than Array<String> or String supported?
src/Slider/TimeSlider.jsx
Outdated
|
|
||
| /** | ||
| * The current value(s). | ||
| * @type {any} |
src/Slider/TimeSlider.jsx
Outdated
| * @return {String} the formatted timestamps | ||
| */ | ||
| formatTimestamp = unix => { | ||
| return moment(unix * 1000).format('DD.MM. HH:mm'); |
There was a problem hiding this comment.
Please make format string configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a time slider that operates on ISO 8601 time strings. Also adds a HOC that updates layers based on the current time setting.
@terrestris/devs please review