Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circle measurement #3474

Merged
merged 10 commits into from
Sep 12, 2023
Merged

Add circle measurement #3474

merged 10 commits into from
Sep 12, 2023

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Aug 25, 2023

Description

This PR adds a new measurement type circle to MeasureButton (credits to @LukasLohoff ). Since ol-util is required at least in version v12, Node has to be upgraded to v18 here as well => ❗ BREAKING ❗ .

Plz review @terrestris/devs

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@ahennr ahennr marked this pull request as draft August 25, 2023 15:04
@ahennr ahennr mentioned this pull request Aug 25, 2023
15 tasks
@ahennr ahennr marked this pull request as ready for review September 12, 2023 13:24
@ahennr ahennr merged commit bdbce95 into main Sep 12, 2023
2 checks passed
@ahennr ahennr deleted the add-circle-measurement branch September 12, 2023 14:27
@dnlkoch
Copy link
Member

dnlkoch commented Sep 13, 2023

🎉 This PR is included in version 23.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants