Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TimeLayerSiderPanel and TimeSlider to function component #3760

Merged
merged 4 commits into from Mar 11, 2024

Conversation

mholthausen
Copy link
Member

@mholthausen mholthausen commented Feb 21, 2024

Description

This refactors the TimeLayerSiderPanel and TimeSlider to a function component.
The property map of TimeLayerSiderPanel will be removed, as it was neither needed nor used.

@terrestris/devs please review

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@mholthausen mholthausen force-pushed the refactor-time-layer-slider-panel branch from 86a962d to 672c7e2 Compare March 8, 2024 13:29
@mholthausen mholthausen changed the title Refactor TimeLayerSiderPanel to function component Refactor TimeLayerSiderPanel and TimeSlider to function component Mar 8, 2024
@mholthausen mholthausen marked this pull request as ready for review March 8, 2024 14:24
@mholthausen mholthausen merged commit 8d86fe9 into rg-future Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants