Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FeatureGrid and AgFeatureGrid to a function component #3770

Merged
merged 15 commits into from Apr 30, 2024

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Feb 29, 2024

Description

This refactors the FeatureGrid and the AgFeatureGrid to function components (and makes use of the shared hook useOlLayer). In addition, common grid properties and variables are extracted to a commonGrid.ts file.

Breaking changes:

  • map prop got removed (makes use of useMap now).
  • prop columnDefs got removed, use default columns instead (inFeatureGrid)
  • Bump aggrid to version 31.1 and bump required OpenLayers dependency to v9
  • Remove prop types dependency

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@dnlkoch dnlkoch changed the base branch from main to rg-future February 29, 2024 17:07
@dnlkoch dnlkoch force-pushed the refactor-feature-grid branch 3 times, most recently from 58a731e to b6cca5c Compare March 7, 2024 10:26
@ahennr ahennr changed the title Refactor FeatureGrid to a function component Refactor FeatureGrid and AgFeatureGrid to a function component Mar 14, 2024
@ahennr ahennr marked this pull request as ready for review March 14, 2024 12:15
@dnlkoch dnlkoch merged commit a3711f1 into rg-future Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants