New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor LayerTree
to a function component
#3772
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: removes props map and toggleOnClick
dnlkoch
force-pushed
the
refactor-layer-tree
branch
from
April 30, 2024 11:45
463656d
to
a7f4a44
Compare
ahennr
approved these changes
Apr 30, 2024
simonseyock
reviewed
Apr 30, 2024
simonseyock
reviewed
Apr 30, 2024
simonseyock
reviewed
Apr 30, 2024
simonseyock
reviewed
Apr 30, 2024
simonseyock
reviewed
Apr 30, 2024
simonseyock
reviewed
Apr 30, 2024
simonseyock
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small suggestion, don't know if it's worth it
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the
LayerTree
component to a function component.BREAKING CHANGES:
map
MapContext.Provider
instead (see example)toggleOnClick
.react-geo-layertree > .ant-tree-node-content-wrapper
(pointer-events)LayerTreeNode
Related issues or pull requests
Pull request type
Do you introduce a breaking change?
Checklist
BSD-2-Clause.
npm test
locally).