Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LayerTree to a function component #3772

Merged
merged 2 commits into from May 2, 2024
Merged

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Mar 13, 2024

Description

This refactors the LayerTree component to a function component.

BREAKING CHANGES:

  • Removed prop map
    • wrap component in MapContext.Provider instead (see example)
  • Removed prop toggleOnClick
    • to enable set a default CSS override for .react-geo-layertree > .ant-tree-node-content-wrapper (pointer-events)
  • Removed LayerTreeNode
    • most likely no migration necessary as no part of the public API

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

BREAKING CHANGE: removes props map and toggleOnClick
@dnlkoch dnlkoch marked this pull request as ready for review April 30, 2024 11:50
Copy link
Member

@simonseyock simonseyock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion, don't know if it's worth it

@dnlkoch
Copy link
Member Author

dnlkoch commented May 2, 2024

Thanks for the reviews!

@dnlkoch dnlkoch merged commit 1a53f04 into rg-future May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants