Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in prop #940

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Typo in prop #940

merged 2 commits into from
Nov 20, 2018

Conversation

marcjansen
Copy link
Member

BREAKING CHANGE

Description:

This renames two ill-named properties

  • In the GeoLocationButton
    • Rename trackingoptions to trackingOptions (Upper case O)
  • In the FloatingMapLogo
    • Rename absolutelyPostioned to absolutelyPositioned (added an i)
    • (Side note: A better name for this would be much appreciated)

Please review, and caution: this is a semver major change

@marcjansen marcjansen merged commit c35977e into terrestris:master Nov 20, 2018
@marcjansen
Copy link
Member Author

Thanks for the review.

@marcjansen marcjansen deleted the typo-in-prop branch November 20, 2018 07:23
@snyk-bot snyk-bot mentioned this pull request Apr 26, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbllmnn hwbllmnn hwbllmnn approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marcjansen @hwbllmnn