Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild tree nodes on moveend event of map if resolution changed #987

Merged
merged 2 commits into from
Jan 16, 2019

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Jan 14, 2019

BREAKING CHANGE | REFACTORING

Description:

Until now, change:resolution has been used to detect resolution changes. However, this has a drawback since it is fired as long the view is animating (see openlayers/openlayers#7402). Since a "final" change:resolution after animation is not fired yet (see here) the moveend event of the map is used to detect changes in current map resolution.

As a consequence Layertree will me rendered less often.

Copy link
Member

@dnlkoch dnlkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, a minor typo only.

src/LayerTree/LayerTree.jsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants