Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies for ol and react #1515

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

mholthausen
Copy link
Member

@mholthausen mholthausen commented Mar 14, 2024

This MR is intended to use the ol9 prepared libraries and the new react-geo versions. After these have been released, the updated package.json and package-lock.json must be adjusted, as they are using a file link currently for react-geo.

In particular, this PR is abreaking change for the shogun-gis-client and

TODO

  • get rid of moment
  • switch from jest to vitest
  • transparency slider moves the node on dragging
  • draw:edit is missing the feature that allows to add properties to a layer
  • a typescript issue arises here, to avoid this adjust the webpack.common.js (not commited!):
- 'ol/': {
-   singleton: true,
-   eager: true,
-   requiredVersion: deps.ol
- }
+ // 'ol/': {
+ //   singleton: true,
+ //   eager: true,
+ //   requiredVersion: deps.ol
+ // }

Copy link
Member

@simonseyock simonseyock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really see if the antd and react updates work that easily. I hope the tests still work in theory?

@ahennr
Copy link
Member

ahennr commented Mar 14, 2024

Since this is a major update of OpenLayers, antd and further utils I prefer to declare this as a breaking change. Could you please change the commit message accordingly @mholthausen ?

@mholthausen mholthausen force-pushed the update-dependencies-for-ol-and-react branch from d98b639 to 0006c54 Compare April 5, 2024 09:33
@mholthausen
Copy link
Member Author

Yes, thanks. Updated the description and the commit. Also added some adjustments to the tests and components as they didn't run properly at first.
There more work to do, especially to to fulfill the typecheck.

@mholthausen mholthausen force-pushed the update-dependencies-for-ol-and-react branch 2 times, most recently from 742f2ed to d7092fc Compare April 29, 2024 13:28
@dnlkoch dnlkoch force-pushed the update-dependencies-for-ol-and-react branch from 4864a3f to 366d35d Compare May 24, 2024 11:25
Copy link

github-actions bot commented May 24, 2024

Title Lines Statements Branches Functions
All Coverage: 21%
22.07% (769/3484) 9.7% (175/1804) 25.99% (177/681)
only changed Coverage: NaN%
Unknown% (0/0) Unknown% (0/0) Unknown% (0/0)

@dnlkoch dnlkoch force-pushed the update-dependencies-for-ol-and-react branch from 366d35d to b234b2d Compare May 27, 2024 11:52
@dnlkoch
Copy link
Member

dnlkoch commented Jun 3, 2024

Note: We tried to switch to vite as bundler since the failing start of the application while using ol as shared module seems to be an open issue in webpack.

See the corresponding PR in the example plugin as well.

@dnlkoch dnlkoch force-pushed the update-dependencies-for-ol-and-react branch 2 times, most recently from fcd2275 to e30dc64 Compare July 5, 2024 08:46
@dnlkoch dnlkoch force-pushed the update-dependencies-for-ol-and-react branch from e30dc64 to d4dfbd6 Compare July 5, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants