feat: adds endpoints to manually create users and groups from the provider #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is missing the appropriate security checks at the moment. |
dnlkoch
reviewed
May 21, 2024
Comment on lines
+101
to
+105
| @PostMapping("/createFromProvider") | ||
| @ResponseStatus(HttpStatus.OK) | ||
| public void createFromProvider() { | ||
| groupProviderService.createAllGroups(); | ||
| } |
There was a problem hiding this comment.
Can we add some notes for the OpenAPI spec? The controllers in the BaseController might be a good inspiration.
And can we also add some error handling?
Comment on lines
+47
to
+51
| @PostMapping("/createFromProvider") | ||
| @ResponseStatus(HttpStatus.OK) | ||
| public void createFromProvider() { | ||
| userProviderService.createAllUsers(); | ||
| } |
| @@ -33,4 +33,5 @@ public interface GroupProviderService<UserType, GroupType> { | |||
|
|
|||
| Group<GroupType> findOrCreateByProviderId(String providerGroupId); | |||
|
|
|||
| void createAllGroups(); | |||
There was a problem hiding this comment.
Just wondering, do we need to flag this commit as breaking?
There was a problem hiding this comment.
It's not breaking anything, is it? It's a new feature.
There was a problem hiding this comment.
Since it's changing an interface, project implementations would need to include the implementation of the newly added method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds endpoints to manually create users and groups from the provider. This is useful in case the users and groups are not created while shogun is running.
Removed the
LoginListenerbecause it is not used anymore.Description
Related issues or pull requests
Pull request type
Do you introduce a breaking change?
Checklist
Apache Licence Version 2.0.
mvn testlocally).