Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posting.setId() should be in WritablePosting #104

Closed
cmacdonald opened this issue Apr 28, 2020 · 1 comment
Closed

Posting.setId() should be in WritablePosting #104

cmacdonald opened this issue Apr 28, 2020 · 1 comment

Comments

@cmacdonald
Copy link
Contributor

Suggested by @tonellotto

@cmacdonald cmacdonald changed the title Posting.setId() should be WritablePosting Posting.setId() should be in WritablePosting Apr 28, 2020
cmacdonald added a commit to tonellotto/terrier-core that referenced this issue Apr 28, 2020
cmacdonald added a commit that referenced this issue May 6, 2020
* removed eclipse hidden files from repo
* updated gitignore to ignore eclipse garbage
* updated version to 5.3-SNAPSHOT in all poms
* commented out integer.compression module from assemblies module
* pass on javadocs and formatting. deprecated stuff that should not be exposed
* pass over lexicon and statistics classes
* pass over pointers and positions
* pass over CollectionStatistics. Some refactoring, some code changes
* english correction on CollectionStatistics method propagated to MemoryCollectionStatistics
* refactor document index classes
* missing javadoc documented. IndexRef class still too complex
* fix assertion
* fixes for collection statistics based on new assertion
* fix bug in unit test based on new collstats assertion
* Posting.setId() should be in WritablePosting #104
* javadoc changes as requested
* removed TODOs and an annotation not required anymore
* added TODO markdown document

Co-authored-by: Craig Macdonald <craig.macdonald@glasgow.ac.uk>
@cmacdonald
Copy link
Contributor Author

Fixed in index-api branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant