update terser to latest version (5) #46

alexander-akait · 2020-08-03T17:24:15Z

Will be great to do it ASAP to avoid multiple dependencies, thanks for work on the package, plus update old deps too 😄 If you need I can help at the end of week

DanielRuf · 2020-08-03T17:48:47Z

to avoid multiple dependencies

Not sure what you mean with this.

plus update old deps too

Which dependencies exactly do you mean?

According to https://github.com/terser/terser/blob/master/CHANGELOG.md#v500-beta0 the minimum required Node version is 10(but the code in package.json still says 6). And there are a few more breaking changes. So this will not happen asap.

This needs further clarification because webpack 4 supports Node 6+.
https://github.com/DanielRuf/html-minifier-terser/blob/master/package.json#L52

cc @fabiosantoscode

alexander-akait · 2020-08-04T10:09:36Z

@DanielRuf You can do major release, as we will do for terser-webpack-plugin. developers who want to support node@6, can you old version, this is a normal technical process, drop old node and update terser is not hard

DanielRuf · 2020-08-04T10:17:18Z

I will wait for the feedback of @fabiosantoscode. I do not plan to maintain two major versions at the same time so the upgrade will not happen soon.

Please keep in mind that dependents like the html-webpack-plugin would use the old version which I would not maintain then.

https://www.npmjs.com/package/html-minifier-terser

developers who want to support node@6, can you old version, this is a normal technical process, drop old node and update terser is not hard

I can not simply drop that because webpack 4 will still support Node 6 for a very long time. So this is not an option. Otherwise there will be issues like #22 and more which produces extra work and makes the upgrade and major version bump senseless for the near future.

DanielRuf · 2020-08-04T10:19:37Z

I'll wait until webpack 5 is released and webpack 4 deprecated.

alexander-akait · 2020-08-04T10:31:54Z

I will wait for the feedback of @fabiosantoscode. I do nopt plan to maintain two major versions at the same time so the upgrade will not happen soon.

Okay, I will do fork and will use it in webpack packages. And you should not maintain two packages, you need keep support the latest version and keep it up to date

What you are trying to do only creates difficulties and problems:

Almost of developers migrate on node@10
Using old version of terser do not have bug fixes, so you can break code
Using it with latest webpack will create duplicate packages, because we will do release terser-webpack-plugin with 5 version today
No new features and fixes from terser
Keeping old verison of deps and support node@6 is potential unsafe, because many old deps other have security problems

alexander-akait · 2020-08-04T10:33:28Z

I'll wait until webpack 5 is released and webpack 4 deprecated.

No need, it only creates problems, most of developers do not use node 6, almost loaders and plugins supports only node@10, you can look at package.json

DanielRuf · 2020-08-04T10:33:56Z

Not sure why this is needed and I don't think this is helpful. This will likely break all webpack 4 setups.

Still, what do you want to resolve by upgrading to terser 5 in this package here?

DanielRuf · 2020-08-04T10:35:43Z

No need, it only creates problems, most of developers do not use node 6, almost loaders and plugins supports only node@10, you can look at package.json

Which package.json? I look at the package.json of webpack. And The html-webpack-plugin maintained by @jantimon.

DanielRuf · 2020-08-04T10:37:07Z

No need, it only creates problems

I see no problem by supporting minimum Node version. Please clarify which problems you mean.
Currently the whole discussion does not provide good reasons to upgrade right now or rush this until webpack 5 is finally released.

alexander-akait · 2020-08-04T10:38:19Z

I update original answer #46 (comment)

DanielRuf · 2020-08-04T10:38:28Z

And you should not maintain two packages

This is not what I mean, if we upgrade (which results in html-minifier-terser v6) we may still have to support v5 by maintaining a second branch (which is done by many big projects).

alexander-akait · 2020-08-04T10:39:03Z

Big projects ~~can~~ should migrate on new node version, supporting EOL version is unsafe

alexander-akait · 2020-08-04T10:40:28Z

Still, what do you want to resolve by upgrading to terser 5 in this package here?

This package uses in html-loader, so we need to upgrade terser to avoid future problems with minimizing

alexander-akait · 2020-08-04T10:41:37Z

Currently the whole discussion does not provide good reasons to upgrade right now or rush this until webpack 5 is finally released.

Are you seriously? Node 6 does not receive security updates, it potentially contains vulnerabilities, no project will use this in production

DanielRuf · 2020-08-04T10:44:43Z

To clarify my opinion:

What you are trying to do only creates difficulties and problems:

Almost of developers migrate on node@10

Which problems / difficulties does this cause? I see none.

Using old version of terser do not have bug fixes, so you can break code

I am still waiting for the feedback from @fabiosantoscode.

Keeping old verison of deps and support node@6 is potential unsafe, because many old deps other have security problems

You did not show any relevant advisories or npm audit reports ;-)

Using old version of terser do not have bug fixes, so you can break code

This can be easily backported.

Big projects ~~can~~ should migrate on new node version, supporting EOL version is unsafe

Well, tell that webpack and others ;-)

Are you seriously? Node 6 does not receive security updates, it potentially contains vulnerabilities, no project will use this in production

Well, tell that webpack and others ;-)

This package uses in html-loader, so we need to upgrade terser to avoid future problems with minimizing

Citation needed, where are currently problems with minimizing? I see no relevant bugfixes at https://github.com/terser/terser/blob/master/CHANGELOG.md#v500

Please calm down and do not rush. At least producing pressure on me does not help at all. And I want to avoid issues like in the past due to breaking installs reported to @jantimon and others.

alexander-akait · 2020-08-04T11:26:46Z

You did not show any relevant advisories or npm audit reports ;-)

Please read node docs about minimum usage, they recommend never to use EOL node version (it is insecurity), safety is always matter

This can be easily backported.

terser does not bug port fixes in old version

Well, tell that webpack and others ;-)

Already, so we drop node@6 and node@8 support from all loaders and plugins, I tell you how core developers of webpack

Citation needed, where are currently problems with minimizing? I see no relevant bugfixes at https://github.com/terser/terser/blob/master/CHANGELOG.md#v500

in operator now taken into account during property mangle.
Fixed infinite loop in face of a reference loop in some situations.

What is it? It is fixes, so if somebody will use it in code, it will be problem.

Please calm down and do not rush. At least producing pressure on me does not help at all. And I want to avoid issues like in the past due to breaking installs reported to @jantimon and others.

Okay, as I said before time to fork this projects and maybe time to fork html-webpack-plugin, lately this creates only problems, my attempt to fix the process leads to nowhere, requests to fix and pay attention to very important things are ignored. I'm not putting pressure on you, I'm just trying to explain that such an approach currently creates problems, and will create even more in the future, I'm trying to prevent them at the start. I don't see any problem with dependency updates and don't use a old node. Supporting EOL node version is the worst idea. webpack@4 support node@6 due historical reasons. The new webpack version might even skip version 10 to avoid the same problem in future. All this I say as a developer who spends most of the time maintaining webpack and webpack ecosystem.

alexander-akait · 2020-08-04T11:28:39Z

And the most important thing - backporting is the last resort when there is no way to update at all, it is a very bad idea to use this as a standard approach

DanielRuf · 2020-08-04T11:38:04Z

Good luck with this. terser 5 is only 3 days old. I see no good reasons to rush this.

alexander-akait · 2020-08-04T11:55:23Z

And please tell me what this package has to do with the webpack? What if I use it in completely different places and ask to do update, because my code is broken due terser bugs? Still don't think this is a problem? i can create repository with issue or will that be ignored too?

fabiosantoscode · 2020-08-10T18:53:04Z

Hey there! I missed my mentions :)

Terser 5 does drop older node support. Thanks for pointing out that package.json still says node 6 :) I'll change it when I have the time.

I don't think there's any rush in moving to Terser 5 either! It's just been released.

The real issue with updating is probably not going to be the node version (as most of your users are probably on node >=10), but the fact that the minify() function is now async (I'm very sorry but I have to update to the new source-map). This will warrant a major bump on this package as well.

Error handling changed (errors are thrown instead of returned) but that shouldn't be a big issue IMO.

DanielRuf · 2020-08-18T16:05:32Z

The real issue with updating is probably not going to be the node version (as most of your users are probably on node >=10), but the fact that the minify() function is now async (I'm very sorry but I have to update to the new source-map). This will warrant a major bump on this package as well.

Error handling changed (errors are thrown instead of returned) but that shouldn't be a big issue IMO.

Ok, it seems we may have to change a few things then and ensure that the code still works as expected. I'll plan some PR for September or October and a major release for the end of this year or next year when probably webpack 5 is released and I can discuss and coordinate this with the other package maintainers so they are aware of the planned roadmap and coming changes.

alexander-akait · 2020-08-18T16:07:52Z

probably webpack 5 is released and I can discuss and coordinate this with the other package maintainers so they are aware of the planned roadmap and coming changes

You may not have noticed, but I am maintainer and I am asking you to do this asap, but you again ignore me

alexander-akait · 2020-08-18T16:08:34Z

But no need, fork is WIP and webpack will be migrate on this

DanielRuf · 2020-08-18T16:11:27Z

You may not have noticed, but I am maintainer and I am asking you to do this asap, but you again ignore me

I am aware of that but I see no good reasons to rush here (only for webpack) =)

Reopening as this is still relevant, not just for webpack. Nothing critical that has to be done now.

abdonrd · 2020-09-11T09:35:05Z

There are any news here about update to Terser 5? Thanks in advance!

DanielRuf · 2020-09-11T11:19:27Z

No news here so far.

fabiosantoscode · 2020-10-02T11:48:35Z

Ok, it seems we may have to change a few things then and ensure that the code still works as expected.

@DanielRuf fortunately await and Promise.resolve() turn non-promise things into promises.

PS I've migrated the terser org to travis-ci.com to fix an issue in PR builds over at the terser repo, hope you don't mind!

laurentpayot · 2020-10-20T07:45:58Z

I found out that my JS code inside my HTML was not minified at all because I was using the now widespread optional chaining operator ?..
Optional chaining operator is supported by Terser since version 5.2.0, but html-minifier-terser only uses version 4.6.3.

It's been a while since Terser 5 release, maybe it's time to update Terser to the latest version so people can use this package with modern JS syntax 😉

DanielRuf · 2020-10-20T08:39:16Z

PRs are very welcome. I have currently no time.

fabiosantoscode · 2020-10-20T12:04:03Z

Please be patient fellow humans. Updating to Terser 5 is not a matter of bumping a version in package.json.

slorber · 2020-10-20T17:50:16Z

Hi.

As the Docusaurus 2 maintainer, we would also benefit from the terser v5 upgrade.
How complex is that upgrade? Can an external contributor easily work on this?

We have weird Yarn behavior (only affecting monorepos), where some users end up running this html-minifier-terser against Terser v5 instead of v4, which make the build fail. This seems to be the case when some other package of the monorepo depends on file-loader. (facebook/docusaurus#3515)

(undefined) TypeError: Cannot read property 'replace' of undefined
    at Object.options.minifyJS (main:18614:28)

My workaround to ensure Terser V4 keep being used is to use nohoist:

"workspaces": {
    "packages": [
      "docs",
      "other-project"
    ],
    "nohoist": [
      "**/html-minifier-terser",
    ]
  },

We already have a few affected users by this problem.

This issue is likely not the fault of this package, but was just curious if others are sharing the same motivations for this terser v5 upgrade, and maybe my workaround will be useful to others in the same situation?

DanielRuf · 2020-10-20T17:53:32Z

We have weird Yarn behavior (only affecting monorepos), where some users end up running this html-minifier-terser against Terser v5 instead of v4, which make the build fail

Even with yarn resolutions?

slorber · 2020-10-20T17:57:21Z

As far as I remember, I tried yarn resolutions and it didn't work. Wasn't able to get it fixed without nohoist.

If you are curious there are repros to try to fix :)
Like this one where yarn install && cd docs && yarn build won't pass: https://github.com/taylorreece/docusaurus-minify-troubles

fabiosantoscode · 2020-10-20T18:13:07Z

I suspect this has to be fixed at the yarn level.

Asking for a version of a package and not getting something outside that range is a very important, very critical task of any package manager.

I suspect that if you have source-map installed then you have two incompatible versions of it installed? The latest one is async (which is why Terser is async)

slorber · 2020-10-21T10:53:41Z

Yes I agree @fabiosantoscode , it's likely a Yarn issue (or maybe related to node resolution too).
I debugged the issue and can clearly see that this package calls Terser 5, and fail on resultPromise.replace() (terser 5) instead of the expected result.replace() (terser 4).

alexander-akait · 2021-02-03T12:14:11Z

I'll wait until webpack 5 is released and webpack 4 deprecated.

@DanielRuf do we need wait something

webpack@5 was released a long time ago

DanielRuf · 2021-02-03T13:06:58Z

I'll wait until webpack 5 is released and webpack 4 deprecated.

@DanielRuf do we need wait something

webpack@5 was released a long time ago

Feel free to create the fork (or provide a PR), I do not have much time at the moment and in the next weeks.

alexander-akait · 2021-02-03T13:10:42Z

@DanielRuf we need to change our API on async, do you agree? Don't wan to waste time

DanielRuf · 2021-02-03T14:07:53Z

I agree with this.

DanielRuf added the webpack5 label Aug 4, 2020

DanielRuf mentioned this issue Aug 10, 2020

Move to some org? #15

Closed

alexander-akait closed this as completed Aug 18, 2020

DanielRuf reopened this Aug 18, 2020

terser locked as off-topic and limited conversation to collaborators Aug 18, 2020

DanielRuf self-assigned this Aug 18, 2020

DanielRuf added this to To do in development via automation Aug 18, 2020

terser unlocked this conversation Aug 22, 2020

abdonrd mentioned this issue Sep 11, 2020

Update terser to v5 open-wc/open-wc#1832

Closed

DanielRuf added the help wanted Extra attention is needed label Oct 20, 2020

slorber mentioned this issue Oct 20, 2020

[v2] Server build fails after updating to 2.0.0-alpha.66 facebook/docusaurus#3614

Closed

pioug mentioned this issue Jan 19, 2021

Update terser@5.5.1 posthtml/htmlnano#133

Closed

sibiraj-s mentioned this issue Jul 7, 2021

Terser 5 #63

Merged

DanielRuf closed this as completed in #63 Aug 30, 2021

development automation moved this from To do to Done Aug 30, 2021

DanielRuf mentioned this issue Sep 6, 2021

Implement a synchronous minify method in v6+ #78

Closed

update terser to latest version (5) #46

update terser to latest version (5) #46

Comments

alexander-akait commented Aug 3, 2020 • edited Loading

DanielRuf commented Aug 3, 2020

alexander-akait commented Aug 4, 2020

DanielRuf commented Aug 4, 2020 • edited Loading

DanielRuf commented Aug 4, 2020

alexander-akait commented Aug 4, 2020 • edited Loading

alexander-akait commented Aug 4, 2020 • edited Loading

DanielRuf commented Aug 4, 2020

DanielRuf commented Aug 4, 2020

DanielRuf commented Aug 4, 2020

alexander-akait commented Aug 4, 2020

DanielRuf commented Aug 4, 2020

alexander-akait commented Aug 4, 2020 • edited Loading

alexander-akait commented Aug 4, 2020

alexander-akait commented Aug 4, 2020

DanielRuf commented Aug 4, 2020 • edited Loading

alexander-akait commented Aug 4, 2020

alexander-akait commented Aug 4, 2020

DanielRuf commented Aug 4, 2020

alexander-akait commented Aug 4, 2020

fabiosantoscode commented Aug 10, 2020

DanielRuf commented Aug 18, 2020 • edited Loading

alexander-akait commented Aug 18, 2020

alexander-akait commented Aug 18, 2020

DanielRuf commented Aug 18, 2020 • edited Loading

abdonrd commented Sep 11, 2020 • edited Loading

DanielRuf commented Sep 11, 2020

fabiosantoscode commented Oct 2, 2020

laurentpayot commented Oct 20, 2020

DanielRuf commented Oct 20, 2020 • edited Loading

fabiosantoscode commented Oct 20, 2020

slorber commented Oct 20, 2020 • edited Loading

DanielRuf commented Oct 20, 2020

slorber commented Oct 20, 2020 • edited Loading

fabiosantoscode commented Oct 20, 2020

slorber commented Oct 21, 2020

alexander-akait commented Feb 3, 2021

DanielRuf commented Feb 3, 2021 • edited Loading

alexander-akait commented Feb 3, 2021

DanielRuf commented Feb 3, 2021

alexander-akait commented Aug 3, 2020 •

edited

Loading

DanielRuf commented Aug 4, 2020 •

edited

Loading

alexander-akait commented Aug 4, 2020 •

edited

Loading

alexander-akait commented Aug 4, 2020 •

edited

Loading

alexander-akait commented Aug 4, 2020 •

edited

Loading

DanielRuf commented Aug 4, 2020 •

edited

Loading

DanielRuf commented Aug 18, 2020 •

edited

Loading

DanielRuf commented Aug 18, 2020 •

edited

Loading

abdonrd commented Sep 11, 2020 •

edited

Loading

DanielRuf commented Oct 20, 2020 •

edited

Loading

slorber commented Oct 20, 2020 •

edited

Loading

slorber commented Oct 20, 2020 •

edited

Loading

DanielRuf commented Feb 3, 2021 •

edited

Loading