Migrating from browserify to rollup #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sibiraj-s, can you please adjust the PR title and description so it gets easier to understand that this is about "change the build setup to rollup for faster / easier builds"? That would be great =) |
Sorry. done. |
No problem, thank you very much =) |
|
cc @XhmikosR |
|
Note - adding |
|
Can I go ahead and merge this? |
I took a quick look and the changes look good to me. Sure, you can go ahead. |
|
Thanks. @DanielRuf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates from browserify to rollup.
New Files created.
dist/htmlminifier.umd.bundle.js(for browsers)dist/htmlminifier.umd.bundle.min.js(for browsers minified)dist/htmlminifier.esm.bundle.js(for scripts using modules in browsers)dist/htmlminifier.js(for nodejs using import script)Also supports new exports syntax. we should be able to provide conditional export of file and also later switch to module without breaking changes.
Breaking change:
dist/htmlminifier.jsis now ESM, the browser version can be found inumd/esm.bundle.js.requireto the window scope.Note: the dist files are not published to npm. hence its very hightly unlike to affect end users.