fix parens output for nullish coalescing operators. Closes #834

terser · Oct 18, 2020 · 8a42649 · 8a42649
1 parent c881c78
commit 8a42649
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/output.js b/lib/output.js
@@ -971,6 +971,10 @@ function OutputStream(options) {
                 return true;
             }
 
+            if (po === "??" && (so === "||" || so === "&&")) {
+                return true;
+            }
+
             const pp = PRECEDENCE[po];
             const sp = PRECEDENCE[so];
             if (pp > sp

diff --git a/test/compress/nullish.js b/test/compress/nullish.js
@@ -127,3 +127,21 @@ nullish_coalescing_mandatory_parens: {
 
     expect_exact: "(x??y)||z;x||(y??z);"
 }
+
+nullish_coalescing_parens: {
+    input: {
+        console.log((false || null) ?? "PASS");
+        console.log(null ?? (true && "PASS"));
+        console.log((null ?? 0) || "PASS");
+        console.log(null || (null ?? "PASS"));
+    }
+
+    node_version: ">=14"
+
+    expect_stdout: [
+        "PASS",
+        "PASS",
+        "PASS",
+        "PASS",
+    ]
+}