Avoid computing the .length of referred arrays in case of mutations. C…

…loses #1380
terser · Apr 18, 2023 · dd6ebd3 · dd6ebd3
1 parent 028514c
commit dd6ebd3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/lib/compress/evaluate.js b/lib/compress/evaluate.js
@@ -359,24 +359,16 @@ def_eval(AST_PropAccess, function (compressor, depth) {
             return obj.length;
         }
 
-        const is_spreadless_array = obj =>
+        const is_spreadless_array =
             obj instanceof AST_Array
             && obj.elements.every(el => !(el instanceof AST_Expansion));
 
         if (
-            is_spreadless_array(obj)
+            is_spreadless_array
             && obj.elements.every(el => !el.has_side_effects(compressor))
         ) {
             return obj.elements.length;
         }
-
-        let fixed;
-        if (
-            obj instanceof AST_SymbolRef
-            && is_spreadless_array((fixed = obj.definition().fixed_value()))
-        ) {
-            return fixed.elements.length;
-        }
     }
 
     if (compressor.option("unsafe")) {

diff --git a/test/compress/evaluate.js b/test/compress/evaluate.js
@@ -821,7 +821,7 @@ safe_array_string_length: {
     }
     expect: {
         const array_ref = [1, leak("side effect")]
-        console.log(4, 2, 2, [id("side eff")]);
+        console.log(4, 2, array_ref.length, [id("side eff")]);
     }
     expect_stdout: "4 2 2 [ 'side eff' ]"
 }