-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid node version #858
Comments
PR #859 |
Same here:
Installed version:
|
same here |
duplicate #854 |
+1 |
1 similar comment
+1 |
+1 |
1 similar comment
+1 |
+1
Installed version:
|
+1 |
+1 |
2 similar comments
+1 |
+1 |
+1
|
here's a temporary workaround for y'all |
That works, big thanks! |
+1 |
Lol, screw this into my company's deployment with a wagon of approvals and signatures |
+1 |
+1000 ;) |
Anybody know why this happens when yarn.lock should be enforcing the same versions of everything? I wouldn't have expected to see this breakage unless someone at my org upgraded something on our project. |
@ollwenjones yarn lock is only enforced if you use |
@mattvb91 it is 100% enabled in our build scripts though. this got past it. unless it's the combination of |
@ollwenjones puuuh not sure, we have also been struggling with both npm's and yarns locking mechanism for the past year |
@mattvb91 Looks like there's a known issue with |
+1 |
Hey there! This is now fixed in 5.3.7. |
So it's correct, that 5.3.7 is incompatible with node 13? |
That is correct. Terser on node 13 works fine when require()d but it's not supported due to a large amount of ESM bugs stopping it from being imported. |
@fabiosantoscode id be happy to make a PR fixing your exports field to work on every v13 version, if you’re interested (it’s a small change; i recently did the same for yargs) |
Hey there @ljharb! If you can do it while maintaining support for the other versions, I would appreciate it! |
Absolutely; PR incoming. |
* fix: ensure "exports" works on all versions of node Per #858 (comment) * Simplify version range Co-authored-by: Fábio Santos <fabiosantosart@gmail.com>
I couldn't install terser because of a version mismatch. I think the trailing comma after each version may be causing the issue:
terser/package.json
Line 9 in 571fd99
I think it should be space-separated
The text was updated successfully, but these errors were encountered: