Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid node version #858

Closed
paleite opened this issue Oct 19, 2020 · 33 comments
Closed

Invalid node version #858

paleite opened this issue Oct 19, 2020 · 33 comments

Comments

@paleite
Copy link

paleite commented Oct 19, 2020

I couldn't install terser because of a version mismatch. I think the trailing comma after each version may be causing the issue:

"node": "^10.0.0,^11.0.0,^12.0.0,>=14.0.0"

I think it should be space-separated

@paleite
Copy link
Author

paleite commented Oct 19, 2020

PR #859

@tomaszs
Copy link

tomaszs commented Oct 19, 2020

Same here:

error terser@5.3.6: The engine "node" is incompatible with this module. Expected version "^10.0.0,^11.0.0,^12.0.0,>=14.0.0". Got "1

Installed version:

14.13.1

@harshitsilly
Copy link

same here

@LoaderB0T
Copy link

duplicate #854

@ycjcl868
Copy link
Contributor

+1

1 similar comment
@ghost
Copy link

ghost commented Oct 19, 2020

+1

@Nelosen
Copy link

Nelosen commented Oct 19, 2020

+1

1 similar comment
@CarlosAzocar
Copy link

+1

@dmoosocool
Copy link

+1

terser@5.3.6: The engine "node" is incompatible with this module. Expected version "^10.0.0,^11.0.0,^12.0.0,>=14.0.0". Got "13.13.0"

Installed version:

13.13.0 14.7.0 14.14.0 

@akryll
Copy link

akryll commented Oct 19, 2020

+1
error terser@5.3.6: The engine "node" is incompatible with this module. Expected version "^10.0.0,^11.0.0,^12.0.0,>=14.0.0". Got "12.19.0"

@dolmira
Copy link

dolmira commented Oct 19, 2020

+1

2 similar comments
@WildXav
Copy link

WildXav commented Oct 19, 2020

+1

@coderrorer
Copy link

+1

@s-dupuis
Copy link

+1

error terser@5.3.6: The engine "node" is incompatible with this module. Expected version "^10.0.0,^11.0.0,^12.0.0,>=14.0.0". Got "14.14.0"

@anachronic
Copy link

here's a temporary workaround for y'all

@jodybrewster
Copy link

here's a temporary workaround for y'all

That works, big thanks!

@ipeshev
Copy link

ipeshev commented Oct 19, 2020

+1
adding you to my own npm blacklist

@akryll
Copy link

akryll commented Oct 19, 2020

here's a temporary workaround for y'all

That works, big thanks!

Lol, screw this into my company's deployment with a wagon of approvals and signatures

@alxkat
Copy link

alxkat commented Oct 19, 2020

+1

@dev7ch
Copy link

dev7ch commented Oct 19, 2020

+1000 ;)

@ollwenjones
Copy link

Anybody know why this happens when yarn.lock should be enforcing the same versions of everything? I wouldn't have expected to see this breakage unless someone at my org upgraded something on our project.

@mattvb91
Copy link

@ollwenjones yarn lock is only enforced if you use yarn --frozen-lockfile its not enabled by default

@ollwenjones
Copy link

@mattvb91 it is 100% enabled in our build scripts though. this got past it. unless it's the combination of --frozen-lockfile and --force ?

@mattvb91
Copy link

@ollwenjones puuuh not sure, we have also been struggling with both npm's and yarns locking mechanism for the past year

@ollwenjones
Copy link

@mattvb91 Looks like there's a known issue with --frozen-lockfile and --force flags at the same time.
yarnpkg/yarn#5215 This is how it happened in our environment, in case anyone else hits the same thing.

@GThairi
Copy link

GThairi commented Oct 19, 2020

+1

@fabiosantoscode
Copy link
Collaborator

Hey there! This is now fixed in 5.3.7.

@sclausen
Copy link

Hey there! This is now fixed in 5.3.7.

So it's correct, that 5.3.7 is incompatible with node 13?

@fabiosantoscode
Copy link
Collaborator

That is correct. Terser on node 13 works fine when require()d but it's not supported due to a large amount of ESM bugs stopping it from being imported.

@ljharb
Copy link
Contributor

ljharb commented Oct 20, 2020

@fabiosantoscode id be happy to make a PR fixing your exports field to work on every v13 version, if you’re interested (it’s a small change; i recently did the same for yargs)

@fabiosantoscode
Copy link
Collaborator

Hey there @ljharb!

If you can do it while maintaining support for the other versions, I would appreciate it!

@ljharb
Copy link
Contributor

ljharb commented Oct 20, 2020

Absolutely; PR incoming.

@ljharb
Copy link
Contributor

ljharb commented Oct 20, 2020

#861

fabiosantoscode added a commit that referenced this issue Oct 22, 2020
* fix: ensure "exports" works on all versions of node

Per #858 (comment)

* Simplify version range

Co-authored-by: Fábio Santos <fabiosantosart@gmail.com>
NicoVogel pushed a commit to NicoVogel/openapi-typescript-codegen that referenced this issue Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests