@__KEY__: Correctly copy annotations when cloning AST_string #1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in some rare cases, Terser does not mangle a
@__KEY__
annotated string literal.I traced this to the annotations not being copied in the AST_String constructor.
It is not clear to me when Terser decides to clone a node, so I wasn't able to construct a minimal test case for this. But testing on a real code-base showed that this change does fix the issue.