Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #207, drop support for Node versions <4.0.0 #210

Merged
merged 3 commits into from
Dec 31, 2018

Conversation

nifgraup
Copy link
Contributor

@nifgraup nifgraup commented Dec 27, 2018

Required to get the tests green in #209.

Alternatively, version 4 could be the minimum version to build terser, but test runs could still execute on older versions of node.js.

@fabiosantoscode
Copy link
Collaborator

I've added iojs and 4 to the .travis.yml. They should work, but you need to specify more process.versions to skip jetstream on.

Also, can you change our minimal supported version in the readme? Or add a note of it?

@fabiosantoscode
Copy link
Collaborator

Nevermind, I can add that note to the README. Will merge and release when #204 is fixed to avoid confusion.

@nifgraup
Copy link
Contributor Author

Jetstream is something I haven't familiarized myself with.

I will let you add to the README and decide if you want to raise just the build requirements to >= 4.0.0 or also the runtime requirements.

I did raise the minimum "engines" in package.json to node >= 4.0.0, I'm not sure if that refers to just to runtime requirements or also build reqs.

@fabiosantoscode
Copy link
Collaborator

@nifgraup "engines" is OK as you left it.

I'll merge this PR. Thanks for doing god's work.

@fabiosantoscode fabiosantoscode merged commit 125e66f into terser:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants