Fix missing istanbul devDependency #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually Terser don't use any functionality of Istanbul and it's better to change test script to exclude Istanbul from it like it was done in #288 One more note that Istanbul 0.4.5 is deprecated |
Cool, if you decide that the other PR handles it in a better way then it's fine with me.
Yeah, I know - I've just noticed failing builds and this was just a quick fix for the problem. |
|
Yeah, Istanbul is on the way out. I appreciate you taking the time to create the PR though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make CI to pass