-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with reduce_vars #363
Conversation
@fabiosantoscode any updates? |
I'm very concerned about this: https://github.com/terser-js/terser/pull/363/files#diff-7a02108b11616cdd07d36b9a138a71cbR1290
|
Nevermind the This PR looks great. Let me investigate what could be the impact of this transformation to a 0 to ensure everything is going to be fine. Don't want to break anything anymore :D |
I think impact will be suboptimal result for some cases, so I suggest to create an issue to not forget to investigate/fix this |
@L2jLiga I've just had a long look. The impact isn't relevant enough that I care about it. The Please remove the TODO comment and this PR can go in. Awesome work! |
safe_to_assign function call was changed for AST_Assignment in 6ccab38 but method was not changed.
TODO comment removed and PR rebased on top of master :) |
@fabiosantoscode let's land this |
Right. I forgot to merge. But I didn't want to ship because I'm working and if something breaks I can't handle it. Starting tomorrow I'm on vacation. Kind of. And I can ship the new version. |
Fixes #354
Fixes #294
Fixes #308