Improve inlining #661
Merged
Improve inlining #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t figure_out_scope information
L2jLiga
approved these changes
Apr 23, 2020
| @@ -3522,6 +3533,7 @@ const pure_prop_access_globals = new Set([ | |||
| return true; | |||
| } | |||
| if (node instanceof AST_This && this instanceof AST_Arrow) { | |||
| // TODO check arguments too! | |||
There was a problem hiding this comment.
Will you continue work on that in this PR?
There was a problem hiding this comment.
Not really, just a note for later. This is because arguments can be used inside arrow functions and it uses the closest non-arrow arguments just like it does with this.
|
@fabiosantoscode what is status of this PR? :) |
fabiosantoscode
added a commit
that referenced
this pull request
Aug 1, 2020
* enable symbols to be created during compression while maintaining most figure_out_scope information * simplify reduce_vars inlining code * remove _ arguments in parse * add this._toplevel to Compressor * recompute scope when inlining a function * remove old TODO comment * deprecate var_names()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe I've improved some aspects of inlining. It became a bit simpler than before. Also, inlining something updates more scope of the parent scope's information than before, fixing #639.
My original goal was to make it so new, unique variable names were always created, and checking for collisions didn't need to happen, but it turns out that generating new names didn't fix all the problems, and people would probably be upset or confused if their variable names were changed without them using the mangle option.
Then I tacked on a change I was interested in, which was to start measuring symbols differently depending on whether mangling was enabled, fixing #321.