Private fields and methods support #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 18, 2021 11:00
L2jLiga
reviewed
Jan 18, 2021
dragomirtitian
approved these changes
Jan 26, 2021
|
Hi @fabiosantoscode I just wanted to know when you can review this pr. Feel free to let me know what I can do to push this forward or anything that I can do to make the review easier. Thank you! |
|
Hey there! I totally missed your updates. This is looking pretty good, and it even has support for private optional properties. I think it's good to merge! |
|
Amazing, thank you! No problem, github notifications can be a bit overwhelming sometimes! |
This was referenced Mar 16, 2021
This was referenced Mar 18, 2021
6 tasks
darkdh
added a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2023
https://chromium-review.googlesource.com/c/chromium/src/+/4218203 WebUI: Roll Terser to v5.16.2 The existing version of Terser is 2 years old (5.3.3) and does not support features like static initialization blocks. No size changes were observed in the Print Preview and Settings .rollup.js files. polymer_bundled.min.js was observed to slightly decrease in size (~30 bytes) when regenerated with reproduce.sh. Bug: 1412524 Change-Id: I0f5d58ac18f3a50cfedc095b278445122d33c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218203 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#1100754} --- The reason we need this is because `terser` that chromium used is too old and it doesn’t support [Private fields and methods](terser/terser#913) so that is why we will see [this](https://bravesoftware.slack.com/archives/C7VLGSR55/p1675990758314239) on Android release build due to `_strip_resource_files = is_android && is_official_build` in `//tools/grit/grit_rule.gni`
25 tasks
darkdh
added a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2023
https://chromium-review.googlesource.com/c/chromium/src/+/4218203 WebUI: Roll Terser to v5.16.2 The existing version of Terser is 2 years old (5.3.3) and does not support features like static initialization blocks. No size changes were observed in the Print Preview and Settings .rollup.js files. polymer_bundled.min.js was observed to slightly decrease in size (~30 bytes) when regenerated with reproduce.sh. Bug: 1412524 Change-Id: I0f5d58ac18f3a50cfedc095b278445122d33c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218203 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#1100754} --- The reason we need this is because `terser` that chromium used is too old and it doesn’t support [Private fields and methods](terser/terser#913) so that is why we will see [this](https://bravesoftware.slack.com/archives/C7VLGSR55/p1675990758314239) on Android release build due to `_strip_resource_files = is_android && is_official_build` in `//tools/grit/grit_rule.gni`
darkdh
added a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2023
https://chromium-review.googlesource.com/c/chromium/src/+/4218203 WebUI: Roll Terser to v5.16.2 The existing version of Terser is 2 years old (5.3.3) and does not support features like static initialization blocks. No size changes were observed in the Print Preview and Settings .rollup.js files. polymer_bundled.min.js was observed to slightly decrease in size (~30 bytes) when regenerated with reproduce.sh. Bug: 1412524 Change-Id: I0f5d58ac18f3a50cfedc095b278445122d33c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218203 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#1100754} In addition, we need https://chromium-review.googlesource.com/c/chromium/src/+/4160349 and https://chromium-review.googlesource.com/c/chromium/src/+/4214416, otherwise we won't have a matching node_modules.tar.gz.sha1 --- The reason we need this is because `terser` that chromium used is too old and it doesn’t support [Private fields and methods](terser/terser#913) so that is why we will see [this](https://bravesoftware.slack.com/archives/C7VLGSR55/p1675990758314239) on Android release build due to `_strip_resource_files = is_android && is_official_build` in `//tools/grit/grit_rule.gni`
darkdh
added a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2023
https://chromium-review.googlesource.com/c/chromium/src/+/4218203 WebUI: Roll Terser to v5.16.2 The existing version of Terser is 2 years old (5.3.3) and does not support features like static initialization blocks. No size changes were observed in the Print Preview and Settings .rollup.js files. polymer_bundled.min.js was observed to slightly decrease in size (~30 bytes) when regenerated with reproduce.sh. Bug: 1412524 Change-Id: I0f5d58ac18f3a50cfedc095b278445122d33c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218203 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/main@{#1100754} In addition, we need https://chromium-review.googlesource.com/c/chromium/src/+/4160349 and https://chromium-review.googlesource.com/c/chromium/src/+/4214416, otherwise we won't have a matching node_modules.tar.gz.sha1 --- The reason we need this is because `terser` that chromium used is too old and it doesn’t support [Private fields and methods](terser/terser#913) so that is why we will see [this](https://bravesoftware.slack.com/archives/C7VLGSR55/p1675990758314239) on Android release build due to `_strip_resource_files = is_android && is_official_build` in `//tools/grit/grit_rule.gni`
darkdh
added a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2023
…ooglesource.com/c/chromium/src/+/4218203) in a less invasive way by pointing it to brave local terser. Otherwise we will have to also cherry-pick https://chromium-review.googlesource.com/c/chromium/src/+/4160349 and https://chromium-review.googlesource.com/c/chromium/src/+/4214416 otherwise we won't have a matching node_modules.tar.gz.sha1 --- The reason we need this is because `terser` that chromium used is too old and it doesn’t support [Private fields and methods](terser/terser#913) so that is why we will see [this](https://bravesoftware.slack.com/archives/C7VLGSR55/p1675990758314239) on Android release build due to `_strip_resource_files = is_android && is_official_build` in `//tools/grit/grit_rule.gni`
mihaiplesa
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 14, 2023
* Revert "Revert "On demand loading wallet-standard" (#17131)" This reverts commit 1e3bae9. * Cherry-pick [WebUI: Roll Terser to v5.16.2](https://chromium-review.googlesource.com/c/chromium/src/+/4218203) in a less invasive way by pointing it to brave local terser. Otherwise we will have to also cherry-pick https://chromium-review.googlesource.com/c/chromium/src/+/4160349 and https://chromium-review.googlesource.com/c/chromium/src/+/4214416 otherwise we won't have a matching node_modules.tar.gz.sha1 --- The reason we need this is because `terser` that chromium used is too old and it doesn’t support [Private fields and methods](terser/terser#913) so that is why we will see [this](https://bravesoftware.slack.com/archives/C7VLGSR55/p1675990758314239) on Android release build due to `_strip_resource_files = is_android && is_official_build` in `//tools/grit/grit_rule.gni`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #702.