Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ASM Opscode dependency #128

Merged
merged 2 commits into from
Jun 26, 2021
Merged

Update the ASM Opscode dependency #128

merged 2 commits into from
Jun 26, 2021

Conversation

wsargent
Copy link
Contributor

@wsargent wsargent commented Jun 26, 2021

Logging instrumentation was not able to instrument nested classes, failing with

[Byte Buddy] ERROR sun.security.pkcs12.PKCS12KeyStore [null, module java.base, Thread[main,5,main], loaded=true]
java.lang.UnsupportedOperationException: NestMember requires ASM7

This is straight forward to fix: ensure that the class visitor is defined with ASM 9 opcodes.

@wsargent wsargent merged commit 0c07ee9 into master Jun 26, 2021
@wsargent wsargent deleted the fix-asm-instrumentation branch June 26, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant