Added missing e4 commands #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Added missing commands stub
diagprov
reviewed
Mar 9, 2020
diagprov
previously approved these changes
Mar 9, 2020
odeke-em
reviewed
Mar 9, 2020
| "testing" | ||
|
|
||
| "github.com/teserakt-io/c2/pkg/pb" | ||
|
|
There was a problem hiding this comment.
Spurious line yet could be anchored with all the "github.com/*" imports down below.
| "github.com/teserakt-io/c2/pkg/pb" | ||
|
|
||
| "github.com/golang/mock/gomock" | ||
|
|
internal/commands/command_test.go
Outdated
| @@ -14,8 +12,8 @@ func TestE4Command(t *testing.T) { | |||
| if err != nil { | |||
| t.Errorf("Expected no error, got %v", err) | |||
| } | |||
| if cmdType != e4.Command(0x01) { | |||
| t.Errorf("Expected type to be %v, got %v", e4.Command(0x01), cmdType) | |||
| if cmdType != 0x01 { | |||
There was a problem hiding this comment.
if g, w := cmdType, 0x01; g != w {
}but even better, let's make constants instead of using magic numbers.
| func (f *factory) CreateRemoveTopicCommand(topic string) (Command, error) { | ||
| cmd, err := e4.CmdRemoveTopic(topic) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Keep the return e4Command(cmd), err anchored to the if, since they are now all part of the same logical block so:
func (f *factory) CreateRemoveTopicCommand(topic string) (Command, error) {
cmd, err := e4.CmdRemoveTopic(topic)
if err != nil {
return nil, err
}
return e4Command(cmd), err
}
internal/commands/factory.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
internal/commands/factory.go
Outdated
| func (f *factory) CreateSetTopicKeyCommand(topic string, key []byte) (Command, error) { | ||
| cmd, err := e4.CmdSetTopicKey(key, topic) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
internal/commands/factory.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing E4 commands as C2 endpoints, along with commands on the c2cli client for:
RemovePubKeyResetPubKeysNewC2KeyNotes on
NewC2KeyFix #15