Added pubkey support to e4client #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
requested changes
Dec 27, 2019
There was a problem hiding this comment.
Thank you for this change @daeMOn63!
A couple of comments:
a) Let's refactor out the repetitive fmt.Print.. and os.Exit(1) into a helper utility logAndExit that looks like this
func logAndExit(fmtStr string, args ...interface{}) {
fmt.Printf(fmtStr, ...args)
os.Exit(1)
}b) Replace os.Open, defer (*os.File).Close, ioutil.ReadAll with ioutil.ReadFile
diagprov
approved these changes
Dec 28, 2019
|
@odeke-em instead of |
daeMOn63
changed the title
|
WIP added - we can hold on pubkey support for after the first release |
odeke-em
requested changes
Jan 3, 2020
| l.Printf("failed to generate key: %v", err) | ||
| return | ||
| } | ||
| l.Printf("public key: %x", key.Public()) |
There was a problem hiding this comment.
This code will unconditionally print "public key" and is going to crash if err != nil and key == nil.
You need to add a return on line 183.
daeMOn63
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.