[bugfix] output responding_code also when not responding

tesibelda · May 20, 2022 · de6bd0c · de6bd0c
1 parent af45f9d
commit de6bd0c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/pkg/vccollector/vccollector_cache.go b/pkg/vccollector/vccollector_cache.go
@@ -251,3 +251,7 @@ func (c *hostState) isHostConnectedAndResponding(skipDuration time.Duration) boo
 
 	return connectedResponding
 }
+
+func (c *hostState) isHostConnected() bool {
+	return !c.notConnected
+}
diff --git a/pkg/vccollector/vccollector_host.go b/pkg/vccollector/vccollector_host.go
@@ -378,9 +378,6 @@ func (c *VcCollector) ReportHostEsxcliResponse(
 				acc.AddError(fmt.Errorf("Could not find host state for %s", host.Name()))
 				continue
 			}
-			if !hostSt.isHostConnectedAndResponding(c.skipNotRespondigFor) {
-				continue
-			}
 
 			hstags := getHostTags(
 				c.client.Client.URL().Host,
@@ -390,8 +387,12 @@ func (c *VcCollector) ReportHostEsxcliResponse(
 				host.Reference().Value,
 			)
 			responding_code = 0
-			if time.Since(hostSt.lastNoResponse) < c.dataDuration {
-				responding_code = 2
+			if !hostSt.isHostConnected() {
+				responding_code = 1
+			} else {
+				if !hostSt.isHostConnectedAndResponding(c.skipNotRespondigFor) {
+					responding_code = 2
+				}
 			}
 			hsfields := getEsxcliFields(
 				responding_code,