-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Efficiency/Range inaccuracy #149
Comments
I will look into it later. A little background information in advance for you to dig into if you want:
Right now TeslaMate uses the ideal range everywhere. |
No disagreement. I think the problem is that for these cars in question, Teslamate is still pulling data for a Model3 number instead of a ModelS number (hence the .189 efficiency rating). I know you said that Teslamate is now identifying the car as a Model S (90D) but are you sure that the charts in question are using that ID, or are they still keying in on the MDL3 code? |
If you have a list of all the efficiency factors let me know. |
OK so the problem isn’t that. Somehow else the wrong range is thus being calculated, but I’m not sure why or how.
From: Adrian Kumpf <notifications@github.com>
Reply-To: adriankumpf/teslamate <reply@reply.github.com>
Date: Friday, September 6, 2019 at 9:48 AM
To: adriankumpf/teslamate <teslamate@noreply.github.com>
Cc: "webmaster@klain.net" <webmaster@klain.net>, Author <author@noreply.github.com>
Subject: Re: [adriankumpf/teslamate] Efficiency/Range inaccuracy (#149)
https://github.com/adriankumpf/teslamate/blob/9c61150bd5614728447e21789ab6edc5169b631e/lib/teslamate/vehicles/identification.ex#L44
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Okay, regarding your initial concerns:
|
I wonder if we have a problem because I'm displaying range in miles vs. kilometers? IN response to your #143 comment, is there a way to force the grafana dashboards to use the other range numbers? |
You can change the units at any time via the web interface. Or if you want to override it for a particular dashboard you could update the dashboard variables. |
I have the units selected as miles in the teslamate option and everything in grafana shows in miles. I was just wondering if the incorrect TR range for the car was coming from a math error there... |
Nope, it's just displaying the ideal range :) |
So instead of ideal, could we not display Typical (which is more realistic)? |
The different names are really confusing but that's exactly what I meant here #143 (comment) |
I see the referencd, but how do we shift from ideal to rated? I don’t see an option to do so…
From: Adrian Kumpf <notifications@github.com>
Reply-To: adriankumpf/teslamate <reply@reply.github.com>
Date: Friday, September 6, 2019 at 4:26 PM
To: adriankumpf/teslamate <teslamate@noreply.github.com>
Cc: "webmaster@klain.net" <webmaster@klain.net>, Author <author@noreply.github.com>
Subject: Re: [adriankumpf/teslamate] Efficiency/Range inaccuracy (#149)
The different names are really confusing but that's exactly what I meant here #143 (comment)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
with rated range I'm referring to the |
Understood. I’ll look forward to the update!
From: Adrian Kumpf <notifications@github.com>
Reply-To: adriankumpf/teslamate <reply@reply.github.com>
Date: Friday, September 6, 2019 at 4:33 PM
To: adriankumpf/teslamate <teslamate@noreply.github.com>
Cc: "webmaster@klain.net" <webmaster@klain.net>, Author <author@noreply.github.com>
Subject: Re: [adriankumpf/teslamate] Efficiency/Range inaccuracy (#149)
In the medium term, it will be possible to switch from ideal to rated range within TeslaMate. The rated range is already recorded. That means you won't lose any data until then.
with rated range I'm referring to the battery_range from the API which is the more realistic one your case. That is NOT possible at the moment.
Closing this ....
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
#143
Describe the bug
The system appears to be using an incorrect value for efficiency when calculating range on the car. As a result, the ranges are all inflated. For my 2017 Model S, 90D it is saying that:
Screen captures attached.
The text was updated successfully, but these errors were encountered: