Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Grafana Docker push fails #3487

Closed
JakobLichterfeld opened this issue Nov 25, 2023 · 7 comments
Closed

CI: Grafana Docker push fails #3487

JakobLichterfeld opened this issue Nov 25, 2023 · 7 comments
Labels
github_actions Pull requests that update Github_actions code

Comments

@JakobLichterfeld
Copy link
Collaborator

JakobLichterfeld commented Nov 25, 2023

The push of new grafana image fails due to auth, @jlestel

https://github.com/teslamate-org/teslamate/actions/runs/6988327850/job/19015781415

v1.28.0

@JakobLichterfeld JakobLichterfeld added the github_actions Pull requests that update Github_actions code label Nov 25, 2023
@rpearson-catdevnull
Copy link

rpearson-catdevnull commented Nov 25, 2023

Was just about to open an issue of not being able to see the LFP dashboards from PR #3311. This is probably related right?

edit: it will be as I’m pulling the :latest tag and that won’t have updated due to the failure 👍

@rpearson-catdevnull
Copy link

rpearson-catdevnull commented Nov 25, 2023

You’re missing the docker login command, which you have in your main teslamate build here, in the build script for your grafana action.

You’ll need to log in for each action due to the scope of the login not persisting between the two actions I believe. They’re separate jobs so will run on two separate action runners

@JakobLichterfeld
Copy link
Collaborator Author

Yeah, assume the same. As soon as the job failed, I switch to pre-release, so not everybody is complaining :-) GHCR images are good.

@jlestel
Copy link
Contributor

jlestel commented Nov 25, 2023

@JakobLichterfeld sorry for the oversight I pushed a fix that should allow you to push correctly.

@JakobLichterfeld
Copy link
Collaborator Author

@JakobLichterfeld sorry for the oversight I pushed a fix that should allow you to push correctly.

No problem. We had already found it in a review, but we were both confused by the accidental deletion of the fork branch :-)

@JakobLichterfeld
Copy link
Collaborator Author

Will double-check tomorrow or on Monday before final releasing :-)

@JakobLichterfeld
Copy link
Collaborator Author

closed with #3491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

No branches or pull requests

3 participants