Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LFP variants of Grafana dashboards #3311

Merged
merged 15 commits into from
Nov 16, 2023
Merged

Add LFP variants of Grafana dashboards #3311

merged 15 commits into from
Nov 16, 2023

Conversation

eden881
Copy link
Contributor

@eden881 eden881 commented Aug 13, 2023

For quite some time now, Tesla equips its lower-range vehicles with batteries that use lithium iron phosphate chemistry (also known as LFP). These batteries are designed to be regularly charged to 100% without the danger of accelerated degradation associated with NMC batteries.

However some dashboards in TeslaMate do not reflect this and display red and yellow indicators when the battery's SOC is high. I have created LFP variants of some dashboards so that owners of LFP-based vehicles can have a slightly better experience when viewing their data.

The added dashboards are:

  • Overview - LFP: The battery level gauge has red and yellow zones only on the lower end. The maximum value of the charging kW gauge has been lowered to 170, as this is the maximum DC charging potential for Tesla's LFP batteries.
  • Charging Stats - LFP: The charge stats table remains green even for entries higher than 80% and 95%.
  • Battery Health - LFP: The current SOC bar has a red zone only on the lower end.

@eden881 eden881 changed the title Add Grafana LFP dashboard variants Add LFP variants of Grafana dashboards Aug 13, 2023
@eden881 eden881 closed this Aug 13, 2023
@eden881 eden881 reopened this Aug 13, 2023
@doronkg
Copy link

doronkg commented Aug 13, 2023

Looks good @eden881!
Very important, I'd like to see these new features.

@zknobody
Copy link

Sorry for the beginner question.
How do I check this out ? My docker instance has the latest build but I don't see these dashboards.

@Dulanic
Copy link
Collaborator

Dulanic commented Nov 13, 2023

Sorry for the beginner question. How do I check this out ? My docker instance has the latest build but I don't see these dashboards.

Copy the proposed file from the source and import dashboard. Its in JSON format.

@Dulanic
Copy link
Collaborator

Dulanic commented Nov 13, 2023

I'm also torn on this, this may be extra noise. I think a long term option we could possiblly use variables to make the existing dashboards change if it is LFP. We should also know if it is LFP from the API, so it could be automatic in that way also. I'm not sure just adding more dashboards is the "cleanest" route .

@NirKli
Copy link
Contributor

NirKli commented Nov 14, 2023

I'm also torn on this, this may be extra noise. I think a long term option we could possiblly use variables to make the existing dashboards change if it is LFP. We should also know if it is LFP from the API, so it could be automatic in that way also. I'm not sure just adding more dashboards is the "cleanest" route .

I think in the same way, I'll try to work on a solution.

@JakobLichterfeld JakobLichterfeld added the area:dashboard Related to a Grafana dashboard label Nov 16, 2023
@JakobLichterfeld
Copy link
Collaborator

Would you like to see this merged and open a seperate PR for a variable based solution?

@eden881
Copy link
Contributor Author

eden881 commented Nov 16, 2023

Would you like to see this merged and open a seperate PR for a variable based solution?

I think so. I also think that a variable based solution is the correct way to go, but I believe it's better to have those dashboards merged in now as they solve the issue, and maybe remove them when a variable is integrated into the main dashboards.

@JakobLichterfeld
Copy link
Collaborator

I added #3438 to track the variable handling idea

@JakobLichterfeld JakobLichterfeld merged commit 450147e into teslamate-org:master Nov 16, 2023
2 checks passed
@JakobLichterfeld JakobLichterfeld added the enhancement New feature or request label Nov 16, 2023
@JakobLichterfeld JakobLichterfeld requested review from JakobLichterfeld and removed request for JakobLichterfeld November 16, 2023 15:25
@eden881 eden881 deleted the lfp-dashboards branch November 16, 2023 15:45
JakobLichterfeld pushed a commit that referenced this pull request Feb 9, 2024
* Create a LFP variant of the overview dashboard

* Adjust overview parameters for LFP

* Name the overview LFP dashboard differently

* Create a LFP variant of the charging stats dashboard

* Create a LFP variant of the battery health dashboard

* Add unique UIDs and titles

* Added a separate retrieval of location data

* Only access location data as a separate api if it isn't available in the regular vehicle_data result

* Improved API with latest version of tesla api docs

* Revert "Merge branch 'patched' of https://github.com/jsight/teslamate into jsight-patched"

This reverts commit e3887db, reversing
changes made to fba87d7.

---------

Co-authored-by: Jesse Sightler <jesse.sightler@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashboard Related to a Grafana dashboard enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants