-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TeslaFi importer to accept newer export formats #3431
Update TeslaFi importer to accept newer export formats #3431
Conversation
Is the ci failure related to the changes in this PR? |
As far as I can see: no. see #3428 |
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
6ddf446
to
c825a30
Compare
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
It is not stale. To summarize the pending thread:
So, is this field essential for the purpose of TeslaMate? Could it be made optionnal and left empty by the importer? |
This pull request has been automatically marked as stale because it has not had recent activity. It could be closed if no further activity occurs. Thank you for your contributions. |
Still waiting far input from reviewer. |
c825a30
to
7717317
Compare
7717317
to
abc4189
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it's much faster than adding the value in x large csv files by hand...
It might be useful to mention the TESLAFI_IMPORT_VEHICLE_ID
in the documentation to show that we can use this env variable to choose the vehicle id on which to import the data (may be in the Requirements section of this file website/docs/import/teslafi.md
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Lgtm. Please also add a description about the env file in the doc, under Environment Variables and additional mention it on the doc page for tesla fi import
a62107f
to
12560ed
Compare
Thank you @ithinuel! |
I am not sure if using "1" as the default id but that's what's suggested in #3158 (comment) and has worked so far.