Add credo lint support #3452
Merged
Add credo lint support #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, had this in my mind as well. |
|
So, can we merge that then? (Can someone fix that error "test/teslamate/vehicles/vehicle/charging_test.exs:94: (test)" with the checks?) |
|
Will look into it by tomorrow (review and ci) |
JakobLichterfeld
requested changes
Nov 20, 2023
JakobLichterfeld
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think having credo support for style linting is desirable, bit surprised we don't already have it.
"mix credo" shows a number of warnings, but this PR is about adding credo checks, not fixing the warnings.
The config file is just the basic created with
mix credo gen.config.