-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update statistics.json: timezone issues addressed #3862
Conversation
Timezone issue addressed.
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
To test this changes, we can update our
do a |
Going to ask a dumb question here (forgive me). How would you remove these 'test' images once you are done testing? Or does it not retain them somehow? Mainly thinking space on my Pi. |
Wondering if "timezone" in all of our dashboard JSONs should be "browser". |
This does not work for me. Or I am not pulling the image correctly 🤷🏻♂️ I continue to see the timezone dropdown. Looking through the JSON, I do not see the iteration to verify it was upped. Followed the guidance above:
But still not working. Tried to prune all of my docker images with |
Good point. There are several ways, but if you want to remove dangling images, this would be safest imo:
see https://docs.docker.com/reference/cli/docker/image/prune/ |
This needs to be tested still... |
AFAICS one is browser, the others are empty, probably also meaning browser. |
I am a bit struggling here... I have two charges: in the database:
Since it is UTC and my local time is Europe/Berlin, the second was indeed on 2024-01-21 00:01 and should show up for the 2024-01-21, but it show up for 2024-01-20. Relevant query:
I tried to apply the timezone correction to the other, but it did not help. Any thoughts? |
Same here. But the images have been produced... |
@JakobLichterfeld is there something we are missing? Does it go in Grafana or TeslaMate service? |
The change is only in Grafana... |
Not really. It must be included in the grafana image. |
I'd like some more testing from users with significant timezone difference to UTC, e.g. UTC+-5 or more... |
UTC -5 (or 6 depending on the time of year) hours and just tested.
One item I did find, testing a use-case from @towster - it seems the Drives dashboard filters out (either) zero duration or zero distance drives. I saw this when comparing the filtered Drives dashboard versus the same day Trip dashboard links off the Statistic page. This might be by design. |
I am approving and merging. Linking all issues such that they are closed when merged. Great work @DrMichael and thank you 😄 |
Hmmm, that is wierd. I removed all teslamate and grafana images, did a fesh pull. And have the new version... |
Is there something in the dashboard JSON I can verify to ensure it is in-fact the latest image? |
The new one uses the new |
The screenshots are from github master? |
Screenshots from my Grafana installation. GitHub master looks correct. Which makes no sense why the timezone is lingering. |
A full sequence of the following (manually, not scripted) did not resolve the issue. Still seeing the timezone dropdown in the Statistics dashboard.
|
@cwanja After the |
|
So, still there... Can you remove them? |
What exactly am I removing? I thought these were the latest images? |
Well, perhaps not. So, I would remove all teslamate and grafana images and repull them... |
"Perhaps not" is a really interesting take on an upgrade. I perform the software upgrade, but also "perhaps not" 😂 Will give it a whirl this evening. |
You can compare the checksums to be sure. But anyways, the issue is still present in 1.29.1 |
Is there any way to dive into the image on gihub? To check the json? |
How do we get the checksums from the images in GitHub? Can we start posting that in the release notes? |
I nuked the Grafana image first and then ran a
Decided to nuke both Grafana and TeslaMate to test. No change.
|
How do we want to continue testing? @DrMichael - what if you nuke your images and test? Could it be that a change you made is lingering in your images? Should we formally open an issue at this point? I will not be local to my install for the next two days, but can test when I get back. |
You mean Docker Hub? https://hub.docker.com/r/teslamate/teslamate/tags |
As I said, issue is present in TelsaMate 1.29.1 and Teslamate Grafana 1.29.1 |
No, of course I made the changes in a separate json... in a different folder. Ok:
Then pull and up:
@JakobLichterfeld when you say, it is present in 1.29.1 and it is not in https://github.com/teslamate-org/teslamate/blob/master/grafana/dashboards/statistics.json, then the build failed. But does not explain, why I see the modification... |
Exactly. @swiffer do you have any idea? |
I'll have to check these when I get back. |
Pay attention, there are several SHA 256 sums from docker images, so docker hub displays the digest SHA 256 from what I know |
can you try pruning the grafana data volume and then restart with 1.29.1? (warning: this would remove any additional dashboards / config done manually in grafana) trying teslamate/grafana:latest gives me a dashboard without Europe/Berlin but making use of $__timezone instead. maybe the change in UID of the dashboard caused an issue? |
any hints in the logs of your grafana container logs ? |
So force deleting grafana image didn't work as reported before. No hints in log. Removing the teslamate-grafana-data volume solved it. |
Interesting. The volume holds /var/lib/grafana, but the jsons are in /dashboards... |
What happens when manually modifying provisioned dashboards within grafana? From what is written here I guess the updated provisioned file should have overwritten the manual changes? |
Finally resolved (for me) in 1.29.2 🎉 |
Change to use $__timezone macro.